Todd Lipcon has submitted this change and it was merged.

Change subject: Check sanity of standard file descriptors when starting daemons
......................................................................


Check sanity of standard file descriptors when starting daemons

This adds a sanity check at daemon startup that the standard file
descriptors are open. If they are closed at startup, then those numeric
FDs will be reused by other open files later, and it's possible that a
library trying to write to stderr accidentally writes to some other open
file (such as our data!)

Change-Id: Ie57efbb63c588e39ac70777ba7b21496aae7fc27
Reviewed-on: http://gerrit.cloudera.org:8080/5030
Reviewed-by: Adar Dembo <a...@cloudera.com>
Reviewed-by: Jean-Daniel Cryans <jdcry...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/init.cc
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie57efbb63c588e39ac70777ba7b21496aae7fc27
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to