Adar Dembo has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5031/1/src/kudu/common/common.proto File src/kudu/common/common.proto: Line 89: // ignore 'write_default_value'. > Could you also add a note about where clients should look for the default v Being pedantic a bit, but the server won't 'ignore' write_default_value; it'll fail a request if it was set but doesn't match read_default_value. http://gerrit.cloudera.org:8080/#/c/5031/1/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: Line 297: ColumnSchemaToPB(col, col_pb); Shouldn't 'flags' propagate into this call? -- To view, visit http://gerrit.cloudera.org:8080/5031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76c7cb599292fac4d7a8edf163d59a1574e897b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
