Adar Dembo has posted comments on this change. Change subject: macOS: fix shared_ptr.h ifdef ......................................................................
Patch Set 1: Looks good, but on Slack you said Kudu largely builds on macOS even without this fix (only the build in client_samples-test fails). Can you figure out why that is? I'd like to understand that before merging this, in case something else is going on. -- To view, visit http://gerrit.cloudera.org:8080/5037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff56316ea55244235f3a44df8e0c3f53da1b35c6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
