Adar Dembo has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5089/2/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: Line 222: TestWorkload workload(cluster_.get()); Couple questions about the workload: 1. Any particular reason why Setup() splits half of the setter calls? If not, can you move it to just before Start()? 2. Some of the overrides make sense (i.e. num replicas). But why did you need to override the write batch size and timeout values? Line 229: SleepFor(MonoDelta::FromSeconds(1)); Why is this needed? -- To view, visit http://gerrit.cloudera.org:8080/5089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a06c31c5ad4e26928a7fcabf24f9fd7a02a7e38 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
