Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup ......................................................................
Patch Set 5: > Are you guys worried about a user somehow accidentally having a > link from their data dir out to something like / ? I'm not sure > there's any real good reason why that would happen, but makes me > just a little nervous. Then everything in / owned by the Kudu user will be deleted. We can avoid that by not following symlinks, or at least not following them out of the data directories (i.e. symlinks that point to stuff within the data dirs could be followed). Though didn't you use a symlink once to redirect Kudu's placement of files (maybe cmeta files?) from one disk to another? I guess that use case wasn't for data directories. -- To view, visit http://gerrit.cloudera.org:8080/5007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299e7b22c3f920430ff5d581cf7a507a83eb0101 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <smyatkinma...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Maxim Smyatkin <smyatkinma...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
