Adar Dembo has submitted this change and it was merged. Change subject: test_util: prefer test_dir_ over GetTestDataDirectory() ......................................................................
test_util: prefer test_dir_ over GetTestDataDirectory() The latter is more expensive to call. Originally I wanted to restrict it entirely to KuduTest, but there are a couple places where we don't have a KuduTest but need to call (e.g. mini cluster constructors). Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7 Reviewed-on: http://gerrit.cloudera.org:8080/5028 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/consensus/log_index-test.cc M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager_util-test.cc M src/kudu/integration-tests/disk_reservation-itest.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_stub-test.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/util/env-test.cc M src/kudu/util/env_util-test.cc M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 12 files changed, 57 insertions(+), 61 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
