Dimitris Tsirogiannis has posted comments on this change. Change subject: KUDU-1747 addColumn API is wrong wrt nullability and default values ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5132/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: Line 129: } I would also expand the test to make sure that I can insert a row that has a null in the addNullableDef column and when I read it back I get the null value and not some default. -- To view, visit http://gerrit.cloudera.org:8080/5132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0706839a3dbe21532afd524e2d3fc020d31a9973 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
