David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/5099/5//COMMIT_MSG Commit Message: PS5, Line 10: set by the tablet server s/set by the tablet server/set by the tablet server to the current clock value when a NewScanRequestPB message is processed successfully. http://gerrit.cloudera.org:8080/#/c/5099/5/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS5, Line 594: CountRows CountRows->CountRowsOnLeaders? http://gerrit.cloudera.org:8080/#/c/5099/5/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: PS5, Line 217: READ_LATEST s/READ_LATEST/not in READ_AT_SNAPSHOT http://gerrit.cloudera.org:8080/#/c/5099/5/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: PS5, Line 295: if (configuration_.has_snapshot_timestamp()) { : if (PREDICT_TRUE(read_mode == KuduScanner::READ_AT_SNAPSHOT)) { : scan->set_snap_timestamp(configuration_.snapshot_timestamp()); : } else { : LOG(WARNING) << "Ignoring snapshot timestamp since in READ_LATEST mode."; : } : } maybe do this within the switch block above? -- To view, visit http://gerrit.cloudera.org:8080/5099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d79024b088ea88fd194cabcb61e640f66326264 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
