Todd Lipcon has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 724: break; > The compiler complains about this: hm, weird, I guess it used to work OK with NULL but maybe glog isn't C++11-savvy and doesn't know how to print nullptr. no big deal -- To view, visit http://gerrit.cloudera.org:8080/4993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e4bbb1cac68474756ea1716cfc4c5420cf503e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
