David Ribeiro Alves has submitted this change and it was merged. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param ......................................................................
Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param All the other methods in this class, of this genre, take one but this one was taking the raw faststring buffer instead. Though it did have the advantage of not forcing the caller to clear() the buffer everytime it was weirdly out of place and might introduce subtle bugs with new semantics for RowChangeListEncoder. Change-Id: I6584b22662b58227a80eaebb7d89199d3ea2498a Reviewed-on: http://gerrit.cloudera.org:8080/4928 Reviewed-by: Todd Lipcon <t...@apache.org> Tested-by: David Ribeiro Alves <dral...@apache.org> --- M src/kudu/common/row_changelist.cc M src/kudu/common/row_changelist.h M src/kudu/tablet/memrowset.cc 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: David Ribeiro Alves: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6584b22662b58227a80eaebb7d89199d3ea2498a Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
