Alexey Serbin has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set ......................................................................
Patch Set 1: > I'm not sure what kind of test you're planning but in the past, for > these types of multi-client changes we've added full-on testing to > on client (unit+integration+whatever else) and only unit to the > other. So likely no need to go beyond unit here, since you've added > a pretty thorough test to the cPP client. > JD wdyt? To me that makes sense -- I can add a simple unit test that would verify that the timestamp is captured from the tablet server response and then used while sending requests to other tablet servers in the context of the same scan operation. -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7207672f7b0cf1307bfa861bda3291b278618016 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
