Mike Percy has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ......................................................................
Patch Set 16: (7 comments) Overall LGTM, I didn't review the new tests yet though http://gerrit.cloudera.org:8080/#/c/4995/16/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 266: DCHECK(right.redo_head != nullptr); nit: can remove this or I guess should be DCHECK(right_last != nullptr) Line 272: DCHECK(left.redo_head != nullptr); nit: could remove or I guess should be DCHECK(left_last != nullptr) PS16, Line 463: want want to make Line 689: void MergeUndoHistories(Mutation* left, Mutation* right, Mutation** head) { How about return the head instead of having to pass a Mutation** Line 1012: << ERROR_LOG_CONTEXT; nit: looks like an extra space http://gerrit.cloudera.org:8080/#/c/4995/16/src/kudu/tablet/deltafile.cc File src/kudu/tablet/deltafile.cc: PS16, Line 749: } nit: inconsistent missing space before brace Line 753: LivenessVisitor<UNDO> visitor = { this, sel_vec}; here too -- To view, visit http://gerrit.cloudera.org:8080/4995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1173b2bea721b376f2b6049be20f57307582c47 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
