Alexey Serbin has posted comments on this change.

Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5223/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:

PS1, Line 488: update_multiplier = 500
>From the commit message, I thought the intention was to reduce number of 
>mutations only for the ASAN builds.

However, in this case the number of mutations would decrease also for non-ASAN 
builds.  If that was the original intention (i.e. reduce number of operations 
for _both_ ASAN and regular modes), it would be nice to reflect that in the 
commit message.  If not, then may be it's worth updating this and add if/else 
involving the ADDRESS_SANITIZER macro?


-- 
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to