Todd Lipcon has posted comments on this change. Change subject: Remove/downgrade a few very verbose useless log statements ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5226/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: Line 208: LOG_EVERY_N(INFO, 10) << "Maintenance manager is disabled. Doing nothing"; why'd you move it from VLOG to INFO? doesn't this make it _more_ noisy? maybe use KLOG_EVERY_N_SECS for every 30 seconds or something instead, if you're going to boost to INFO level? Also, should use the KLOG_* macro rather than LOG_* to avoid TSAN issues http://gerrit.cloudera.org:8080/#/c/5226/2/src/kudu/util/thread.cc File src/kudu/util/thread.cc: Line 546: VLOG(10) << "Started thread " << t->tid()<< " - " << category << ":" << name; I actually find these info messages pretty useful at vlog=2, since we've had a fair number of issues with things like threads starting/stopping more frequently than necessary, taking a long time to start, etc. -- To view, visit http://gerrit.cloudera.org:8080/5226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7863f067f49cc7432e8ca3b532a208d3c4005300 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
