David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5188/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: PS7, Line 663: final long timestamp don't you have a different name for this on a follow up patch? or is it a different Response class? mind making these consistent? http://gerrit.cloudera.org:8080/#/c/5188/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java: PS7, Line 20: import static org.junit.Assert.*; don't use star imports -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7207672f7b0cf1307bfa861bda3291b278618016 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
