Alexey Serbin has posted comments on this change. Change subject: util: add file cache ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5146/5/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS5, Line 261: readlink(p.c_str(), buf.get(), size) Wouldn't it be cheaper to use stat() call instead? Using stat()/lstat() would allow to skip allocation of the buffer. Another observation for MacOS X is that if using readlink command-line utility on /dev/fd/xxx items always return an error (not sure whether it calls readlink() system call). Using the stat cmd-line utility at least returns OK for 0, 1 and 2. -- To view, visit http://gerrit.cloudera.org:8080/5146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26d02f71b0a9644de0b669875941adae5f426345 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
