Hello Adar Dembo, Dimitris Tsirogiannis, Todd Lipcon, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5262 to review the following change. Change subject: Update debug partition and row printing ...................................................................... Update debug partition and row printing This commit updates the debug printing of rows and partitions in metrics, log messages, and web UIs. The new format is one we have settled on after consulting with committers on Apache Impala. In all cases I think it makes it easier to work with complex partitions. The most invasive aspect of this change is that string and binary column values are now printed with quotes, which affects a bunch of otherwise unrelated tests. I attempted to minimize as much of the duplication as possible in debug formatting functions in partition.cc, but there is still a lot of duplication that was unavoidable (this was true before making this change as well). Change-Id: I4c444b155fe6621af65b86020be105fe56ae18ef --- M src/kudu/client/batcher.cc M src/kudu/client/client-test.cc M src/kudu/common/encoded_key-test.cc M src/kudu/common/key_util-test.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/row_changelist-test.cc M src/kudu/common/row_operations-test.cc M src/kudu/common/scan_spec-test.cc M src/kudu/common/schema-test.cc M src/kudu/common/types.h M src/kudu/master/master-path-handlers.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/composite-pushdown-test.cc M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/major_delta_compaction-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/tablet-pushdown-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tools/kudu-ts-cli-test.cc M src/kudu/tserver/tablet_server-test.cc 25 files changed, 479 insertions(+), 449 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/5262/1 -- To view, visit http://gerrit.cloudera.org:8080/5262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c444b155fe6621af65b86020be105fe56ae18ef Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>