David Ribeiro Alves has posted comments on this change. Change subject: WIP: Support safe time advancement on replicas in the absense of writes ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5240/3/src/kudu/consensus/time_manager.cc File src/kudu/consensus/time_manager.cc: Line 211: } // consensus > warning: namespace 'consensus' ends with an unrecognized comment [google-re Done Line 212: } // kudu > warning: namespace 'kudu' ends with an unrecognized comment [google-readabi Done http://gerrit.cloudera.org:8080/#/c/5240/3/src/kudu/consensus/time_manager.h File src/kudu/consensus/time_manager.h: Line 34: TimeManager(const scoped_refptr<server::Clock>& clock); > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/5240/3/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: Line 240: Status WaitForSnapshotWithAllCommitted(Timestamp timestamp, > warning: function 'kudu::tablet::MvccManager::WaitForSnapshotWithAllCommitt Done -- To view, visit http://gerrit.cloudera.org:8080/5240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
