Todd Lipcon has posted comments on this change. Change subject: binary_plain_block: avoid a virtual call in hot path ......................................................................
Patch Set 3: Code-Review-1 Dan and I actaully just chatted, and it sounds like a better solution with equivalent perf results may be to mark these encoder classes as 'final', so the compiler knows it can devirtualize such calls. -- To view, visit http://gerrit.cloudera.org:8080/5202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b8337868330b43595a275e837a448e3ba0c066 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
