Alexey Serbin has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util/async_logger.cc File src/kudu/util/async_logger.cc: PS4, Line 39: AsyncLogger::~AsyncLogger() {} nit: may be, just remove it and use ~AsyncLogger() = default; in the header? PS4, Line 128: swap nit: would std::swap() work for AsyncLogger::Buffer as is? http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util/async_logger.h File src/kudu/util/async_logger.h: PS4, Line 124: |= Is this bitwise operator safe for booleans? PS4, Line 134: DISALLOW_COPY_AND_ASSIGN(Buffer); I think for this to do what's is intended to do, it should be in the 'private' section, not 'public' one. -- To view, visit http://gerrit.cloudera.org:8080/5321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a0a29fa00a988a53a15d2c726ce5d49018f4d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
