David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5346/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS2, Line 1687: if (PREDICT_FALSE(!(s.ok() || s.IsIllegalState()))) { PREDICT_FALSE(!s.ok() && !s.IsIllegalState()) is slightly more readable (don't have to mentally apply the negation) also maybe move the comment above about availability here? -- To view, visit http://gerrit.cloudera.org:8080/5346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
