David Ribeiro Alves has posted comments on this change. Change subject: Add integration tests for duplicate keys ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5349/8/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 1396: } > hrm, is this necessary? WaitForRowCount() uses ScanReplica() which has the I saw a failure of this test where it showed the second row first. I assumed since the WaitForRowCount didn't fail it was misordered. if you're saying it can't be then something else is wrong. I removed this. When it fails again we can look more. -- To view, visit http://gerrit.cloudera.org:8080/5349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d018281d412ae034bd7b70c8311077a52b2795d Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
