Todd Lipcon has posted comments on this change. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5353/3/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 494: ASSERT_OK(cluster_->tablet_server(kTsIndex)->Restart()); > Seems like a pretty important omission. What was the effect? basically made this part of the test a no-op: the WaitForTSToCrash() below used to silently ignore if the TS wasn't started at that point, whereas I added a CHECK in this patch that verifies it's in the expected state. -- To view, visit http://gerrit.cloudera.org:8080/5353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8d9ae38efa65123ae69097a76c113b9709c3484 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
