Todd Lipcon has posted comments on this change. Change subject: [i-tests] TestWorkload::set_num_tablets() accepts 1 ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5347/1//COMMIT_MSG Commit Message: Line 7: [i-tests] TestWorkload::set_num_tablets() accepts 1 nit: this summary line is a bit confusing about whether the commit is stating a bug (that it currently accepts 1, but shouldn't), or fixing a bug (that it should accept 1, but doesn't). Would be better to write "should accept 1" or "Fix TestWorkload to allow set_num_tablets(1)" or something for better clarity (obviously it's explained below but often I end up looking at git log --oneline or just skimming a git log) -- To view, visit http://gerrit.cloudera.org:8080/5347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9d0e06550fffdd6a04f6bfba53fe873fb33749 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
