Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5354 to review the following change. Change subject: ssl_factory: avoid a non-POD (vector<>) in static storage ...................................................................... ssl_factory: avoid a non-POD (vector<>) in static storage The global vector<Mutex*> in static storage was causing ASAN test failures when I looped rpc-test's keepalive test with SSL enabled[1]. The issue is that the static storage destructor could run concurrently with other threads still trying to access the SSL mutexes. Since this mutex list is purposefully leaked anyway, it's better to just use a C-style array. [1] http://dist-test.cloudera.org/job?job_id=todd.1480910327.10622 Change-Id: I859aefd932d62fa8619650fcc795d3676187ceb4 --- M src/kudu/util/net/ssl_factory.cc 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/5354/1 -- To view, visit http://gerrit.cloudera.org:8080/5354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I859aefd932d62fa8619650fcc795d3676187ceb4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org>