Todd Lipcon has submitted this change and it was merged. Change subject: ts_recovery-itest: reduce test flakiness ......................................................................
ts_recovery-itest: reduce test flakiness In the flaky test dashboard, this test case was flaky in two cases: 1) in TSAN builds sometimes it wouldn't write fast enough to trigger lots of rolls. In that case, the "wait for crash in 60 seconds" might not trigger. 2) In DEBUG builds, sometimes the 50% chance of crashes allowed it to write 10+ segments before crashing (0.5^10 = 1/1000 times). With this many log segments, the bootstrap could take long enough that the verification on restart would time out. This addresses the issue by (a) writing larger ops, so that logs would roll quicker with fewer ops required, and (b) increasing the crash probability so that it needs fewer rolls to crash on average. Change-Id: I4d5018636d20a4663e84071e91f573b86e309a29 Reviewed-on: http://gerrit.cloudera.org:8080/5351 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d5018636d20a4663e84071e91f573b86e309a29 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>