Mike Percy has posted comments on this change. Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING ......................................................................
Patch Set 3: (3 comments) The JIRA (KUDU-1407) talks about evicting a failed replica, but here you are tablet copying a failed replica, so having some discussion about the design of this in the commit message would help. http://gerrit.cloudera.org:8080/#/c/5352/3//COMMIT_MSG Commit Message: PS3, Line 7: evcited evicted Line 9: Fixes replica eviction failure where a follower returning Please provide a detailed description of how you are fixing this problem and what the different cases are http://gerrit.cloudera.org:8080/#/c/5352/3/src/kudu/tserver/tablet_server_test_util.cc File src/kudu/tserver/tablet_server_test_util.cc: Line 34: const char* TabletServerTestBase::kTableId = "TestTable"; Shouldn't we put this in a new file tablet_server-test-base.cc ? -- To view, visit http://gerrit.cloudera.org:8080/5352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I554ad61f25a7de78eda60fd50228e0f015c1b625 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
