Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: Line 61: return FLAGS_block_manager_max_open_files; How do you feel about comparing the flag value against the limit? Could save some operators by catching mistakes early instead of later in production when they actually start running out of fds. -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
