Todd Lipcon has posted comments on this change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" binding to wildcard address ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5378/1//COMMIT_MSG Commit Message: PS1, Line 7: binding to wildcard address the tool isn't binding to a wildcard, but rather trying to connect to a wildcard http://gerrit.cloudera.org:8080/#/c/5378/1/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 68: DEFINE_bool(ts_use_wildcard_addr, false, this should be one of the options set via the minicluster API before starting it, rather than a gflag http://gerrit.cloudera.org:8080/#/c/5378/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: Line 269: Status HostPortPBFromSockaddrReplaceWildcard(const Sockaddr& addr, HostPortPB* hp) { despite this being convenient, it's a "no-no" to have util/ depend on common/ since it's a cyclic dependency. Also util/ should be general utility code whereas common/ is full of very Kudu-specific stuff. http://gerrit.cloudera.org:8080/#/c/5378/1/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: PS1, Line 118: HostPortHostPortPB typo Line 121: Status HostPortPBFromSockaddrReplaceWildcard(const Sockaddr& addr, HostPortPB* hp); why not just use HostPortFromSockaddr as above, and then convert it to a PB? -- To view, visit http://gerrit.cloudera.org:8080/5378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5d0a37b39a3774caab5b5d8dba3d9750bf5f21f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
