Todd Lipcon has posted comments on this change. Change subject: WIP integration test for snapshot scans ......................................................................
Patch Set 8: (2 comments) need to look at this in some more detail tomorrow. definitely needs some updates on comments to explain what the scan workload is, etc, not entirely following, but admittedly jetlagged :) http://gerrit.cloudera.org:8080/#/c/5375/8/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 721: last_write_ts_for_tests_ = rpc.resp().has_timestamp(); this doesn't seem right at all... don't you mean resp().timestamp()? and maybe a std::max? http://gerrit.cloudera.org:8080/#/c/5375/8/src/kudu/integration-tests/test_workload.h File src/kudu/integration-tests/test_workload.h: Line 166: int64_t rows_inserted() const { a little confused.. you changed the sense of this variable internally but this accessor isn't changed? -- To view, visit http://gerrit.cloudera.org:8080/5375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
