David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement ......................................................................
Patch Set 28: (3 comments) http://gerrit.cloudera.org:8080/#/c/5240/27/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS27, Line 1198: fail. : // Once we have that functionality we'll have to revisit this. > nit: two sentences Done Line 1204: // If we stopped before reaching the end we failed to prepare some message(s) and need > but in the meantime don't we want to do this only if we prepared all ops? i sure, makes sense and it's defensive though I'm not sure it matters in the current implementation. http://gerrit.cloudera.org:8080/#/c/5240/28/src/kudu/consensus/time_manager.cc File src/kudu/consensus/time_manager.cc: PS28, Line 184: // Pre-flight checks, make sure we've heard from the leader recently and that safe time : // isn't lagging too much. maybe we should do a GetSafeTime() call here so that if we're leader we 're less likely to trip the leader check (though we do call it in every heartbeat). -- To view, visit http://gerrit.cloudera.org:8080/5240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e Gerrit-PatchSet: 28 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
