Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5363/4/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: Line 44: int num_tablets); > Let's change it later if it seems super annoying. I don't think this is ver I ended up adding defaults for all of these after all. Line 46: const MonoDelta kTimeout = MonoDelta::FromSeconds(30); > In my opinion, let's not worry about it in the spirit of YAGNI. I actually ended up needing to bump this value for one test, so I changed this to kDefaultTimeout. PS4, Line 121: WaitUntilTabletRunning > This test fails reliably for me. I'll loop it to double check. This turned out to be a little flaky in RELEASE mode so I ended up doing the thread thing and got it to be reliable. -- To view, visit http://gerrit.cloudera.org:8080/5363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f3ec35885dbf1a81c23ac10b1c9556dfddbd4b7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
