Dan Burkert has submitted this change and it was merged. Change subject: KUDU-861 Support changing default, storage attributes ......................................................................
KUDU-861 Support changing default, storage attributes This patch adds support for adding, changing, or removing column defaults and changing the storage attributes of a column. Changes to a column are encoded as a ColumnSchemaDelta, which can be merged with a ColumnSchema to change it. Changing type and nullability of a column is still unsupported. No failures in 100+ iterations of alter_table-randomized-test. I also ran into an issue with altering RLE columns: 1. Add an RLE-encoded column to a table 2. Alter the column 3. Scan the column 3 will cause a check failure on scanning to pos 0 of an empty RLE block. Test and fix included. Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c Reviewed-on: http://gerrit.cloudera.org:8080/4310 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <danburk...@apache.org> --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M src/kudu/cfile/rle_block.h M src/kudu/client/client-test.cc M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/value-internal.h M src/kudu/client/value.cc M src/kudu/common/common.proto M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol.cc M src/kudu/common/wire_protocol.h M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto 19 files changed, 937 insertions(+), 117 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>