Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5403/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 346: max_num_blocks_(block_manager->block_limits_by_data_dir_[data_dir]), can you use FindOrDie here? Line 1828: return major <= 2 && minor <= 6 && patch <= 32 && extra < 674; is this right? seems like it would count '1.7.0.0' as newer. maybe easier to use something like: return std::make_tuple(major, minor, patch, extra) < std::make_tuple(2, 6, 32, 674)? or even better, use autodigit string comparisons from gutil/strings/numbers.h. The following seems to pass your test: bool IsBuggyEl6Kernel(string v) { autodigit_less lt; return v.find("el6") != string::npos && lt(v, "2.6.32-674"); } -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
