Haijie Hong has posted comments on this change. Change subject: Tightening ScanSpec primary bounds when range predicate exists ......................................................................
Patch Set 4: (6 comments) > (7 comments) http://gerrit.cloudera.org:8080/#/c/5360/2/src/kudu/common/key_util.cc File src/kudu/common/key_util.cc: Line 155: memcpy(cell_ptr, &inc, sizeof(inc)); > I don't think it's necessary to do any copying of the data here - you shoul Done PS2, Line 209: break_loop = > I think it makes sense to think about this in terms of exclusive vs. inclus Done PS2, Line 226: C > align with 'row' above. Done PS2, Line 251: predicates == 0) { return 0; } > change this to Done http://gerrit.cloudera.org:8080/#/c/5360/2/src/kudu/common/key_util.h File src/kudu/common/key_util.h: Line 64: bool TryDecrementCell(const ColumnSchema &col, void *cell_ptr); > Please add unit tests to key_util-test.cc for this method. Done http://gerrit.cloudera.org:8080/#/c/5360/2/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: Line 184: SCOPED_TRACE(spec.ToString(schema_)); > Could you add a few cases for LT predicates on non-decrementable values of I have added non-decrementable string test cases. I think non-decrementable int predicate will be simplified as PredicateType::None. -- To view, visit http://gerrit.cloudera.org:8080/5360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I931a617605434700352d285fc2039033cf9eb07e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Haijie Hong <honghai...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Haijie Hong <honghai...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
