Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5549/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: PS1, Line 282: with predicates > remove 'with predicates' Done http://gerrit.cloudera.org:8080/#/c/5549/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java: Line 203 > I don't think we should just remove this - it's arguably a public API. Mmm you're right, might not be ABI compatible. -- To view, visit http://gerrit.cloudera.org:8080/5549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f3dd9dad7bac1d005bd3eead8df33005c7f8c58 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
