Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Clang tool for replacing DebugString calls ......................................................................
Patch Set 1: (2 comments) I don't have a strong opinion on whether to merge this now or later. If we're going to merge it now, I suppose it'd be nice to clean up run-pb-refactor.sh a bit to make more what's going on more clear. But we could just as easily wait. http://gerrit.cloudera.org:8080/#/c/5560/1//COMMIT_MSG Commit Message: PS1, Line 23: 8 Probably $(nproc), right? PS1, Line 30: or we could commit it and later repurpose : it (in a simpler form) as a pre-commit check that no new calls to : DebugString are added. +1 to this -- To view, visit http://gerrit.cloudera.org:8080/5560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If74fc3cc69c3d6048abaa3b0d1f1ff2b2aaeec00 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
