Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Redaction support for protobufs ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5553/4/src/kudu/util/pb_util_test.proto File src/kudu/util/pb_util_test.proto: PS4, Line 25: optional string secure2 = 4 [(kudu.REDACT) = true];; : repeated string repeated_secure = 5 [(kudu.REDACT) = true];; Nit: extra semi-colons here. -- To view, visit http://gerrit.cloudera.org:8080/5553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes