Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/project.clj File java/kudu-jepsen/project.clj: Line 1: (defproject kudu "0.1.0-SNAPSHOT" > Is this file necessary? Seems like we should have either the pom.xml or pr It seems you are right -- we don't need this one since we have pom.xml which uses maven-clojure-plugin. Removing. http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj: Line 32: (when (> (count (:masters test)) 1) > Why only set the master addresses when there are more than one master? Thi Good idea -- I'll do this in one of the follow-up patches. PS4, Line 54: > trailing whitespace Done PS4, Line 59: into [] > I don't think the 'into []' is necessary, str/join should work fine over a Done PS4, Line 59: efn > this could be a def I would prefer to keep some symmetry here: ntp-server-config and ntp-slave-config are both functions. PS4, Line 63: into [] > Same. Done -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
