Alexey Serbin has posted comments on this change. Change subject: [jenkins] added JEPSEN build configuration ......................................................................
Patch Set 3: > > > I think you've pretty much abandoned this in favor of a > dedicated > > > Cloudera-internal jepsen nightly test, right? > > > > This script is used to run > > http://sandbox.jenkins.cloudera.com/view/Kudu/job/kudu-jepsen/ > > > > I can separate this into another file, if needed. > > Oh I see. Do you think this approach is cleaner than a standalone > script a la benchmarks.sh or tpch.sh? I don't think it's cleaner. I just used it because I initially started it as an update for the jenkins build script. By the time I submitted this patch, I still had some wild ideas that with additional provisions to create virtual machines from the script (like those we use for dist_test), we could make it run as a pre-commit check (that was the 'ideal' target we initially discussed with David). Now I understand that the consensus is that this test is more like a system test which should not be run with every commit. That's said, I think the approach like benchmarks.sh or tpch.sh is a better/cleaner fit here. I'll update this patch and the Jenkins job at http://sandbox.jenkins.cloudera.com/view/Kudu/job/kudu-jepsen/ accordingly. -- To view, visit http://gerrit.cloudera.org:8080/5559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2576717dc8fff3fe2c275f29c2c06eb0d35bddc Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
