Hello Dinesh Bhat, Lars Volker, Adar Dembo, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5620 to review the following change. Change subject: Add Google Breakpad support to Kudu ...................................................................... Add Google Breakpad support to Kudu This patch enables Google Breakpad for the kudu-tserver and kudu-master processes. Breakpad part of the crash-reporting infrastructure open-sourced by Google. It is also used by Mozilla Firefox and Google Chrome. When a process crashes, Breakpad writes a small dump file called a minidump to disk. Since these files are typically only a few MB in size, this allows users to share critical crash information with developers for offline analysis. By default, on crash, minidump files are written to a subdirectory of the default log directory for a given Kudu daemon process. Changes in this patch: * Add breakpad to thirdparty. * Add breakpad source archive creation script (Breakpad does not do releases). * Add "-system $PREFIX/includes/breakpad" to the build command line, because breakpad does not properly namespace its includes (however it installs them to their own directory). * Pull in (modified) util/minidump.{cc,h} from Apache Impala (incubating). The modifications mostly consist of removing use of boost::filesystem and conformance to the Kudu code style guidelines. * Enable breakpad support for the kudu-tserver and kudu-master process startup routines. Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f --- M .ycm_extra_conf.py M CMakeLists.txt A cmake_modules/FindBreakpadClient.cmake M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/external_mini_cluster.cc A src/kudu/integration-tests/minidump_generation-itest.cc M src/kudu/master/master_main.cc M src/kudu/tserver/tablet_server_main.cc M src/kudu/util/CMakeLists.txt A src/kudu/util/minidump.cc A src/kudu/util/minidump.h M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/scripts/make-breakpad-src-archive.sh M thirdparty/vars.sh 16 files changed, 501 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5620/1 -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com>