Adar Dembo has posted comments on this change. Change subject: env: Add GetCurrentWorkingDir() and ChangeDir() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5629/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 896: unique_ptr<char, FreeDeleter> wd(get_current_dir_name()); // GNU extension. Is this more or less portable than getcwd(nullptr, 0), which also allocates memory? Would be good to check on macOS; I'd expect that extension to getcwd() to be more portable than get_current_dir_name(). -- To view, visit http://gerrit.cloudera.org:8080/5629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
