Mike Percy has posted comments on this change. Change subject: path_util: Add SplitPath() helper function ......................................................................
Patch Set 1: (2 comments) I am going to merge this into the CreateDirsRecursively() CR per Todd's request. http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.cc File src/kudu/util/path_util.cc: Line 56: vector<string> SplitPath(const string &path) { > Here too. Done http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.h File src/kudu/util/path_util.h: Line 43: std::vector<std::string> SplitPath(const std::string &path); > Nit: const std::string& path Done -- To view, visit http://gerrit.cloudera.org:8080/5628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
