Dinesh Bhat has posted comments on this change.

Change subject: EMC: Don't reuse data dir for log dir
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5619/3//COMMIT_MSG
Commit Message:

PS3, Line 11: .
It would be nice if we could elaborate the problem with current directory 
structure here, looking at the COMMIT_MSG alone the intent of the patch wasn't 
totally clear to me.


http://gerrit.cloudera.org:8080/#/c/5619/3/src/kudu/integration-tests/external_mini_cluster.cc
File src/kudu/integration-tests/external_mini_cluster.cc:

PS3, Line 809: process
Do we want to note the addition of this in the COMMIT_MSG ?


-- 
To view, visit http://gerrit.cloudera.org:8080/5619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba23c429989df524da51eb012a491766df06e955
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to