Todd Lipcon has posted comments on this change.

Change subject: KUDU-1821. Noisy warning from catalog manager
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5637/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

PS2, Line 392: l.catalog_status().posix_code() == CatalogManager::kStarting
Not following this. We don't set any posix code when we return 
ServiceUnavailable. I think you just want to check .IsServiceUnavailable()


-- 
To view, visit http://gerrit.cloudera.org:8080/5637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9b8577e4d857c63df6e66c10d6cf20270cd41e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <junhe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to