Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart ......................................................................
KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart MiniCluster and ExternalMiniCluster utility classes follow opposite semantics for restart. For eg, ExternalMiniCluster::Restart() expects that all the nodes must be shutdown before we restart, whereas MiniCluster::Restart() expects that all servers are up and running so that it can internally execute shutdown and start in that order. This patch changes the semantics of MiniCluster::Restart() to follow that of ExternalMiniCluster::Restart() to keep them consistent and the existing tests are modified to follow the new semantics of MiniCluster::Restart(). Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633 Reviewed-on: http://gerrit.cloudera.org:8080/5598 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <jdcry...@apache.org> Reviewed-by: Mike Percy <mpe...@apache.org> Reviewed-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/client/client-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/master/mini_master.cc M src/kudu/master/mini_master.h M src/kudu/tserver/mini_tablet_server.cc 9 files changed, 17 insertions(+), 10 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Mike Percy: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org>