Todd Lipcon has posted comments on this change. Change subject: Doc review for 1.2 ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: PS1, Line 376: DISTRIBUTE BY HASH INTO (id) 16 BUCKETS > You mean I'm documenting the 2.7 syntax since 2.8 isn't released yet. But you're right it should say (id) PS1, Line 413: DISTRIBUTE BY HASH(name) INTO 8 BUCKETS > Also new syntax: same (2.7 syntax) PS1, Line 448: DISTRIBUTE BY RANGE (_id) > PARTITION BY I believe that's a misconception PS1, Line 449: SPLIT ROWS((1439560049342), : (1439566253755), : (1439572458168), : (1439578662581), : (1439584866994), : (1439591071407)) > Now the syntax is different with 'PARTITION x <= VALUES < y'. I'm not sure 2.7 syntax PS1, Line 482: '\<', '\>', `>=`, or `IN` > Does this apply for BETWEEN also, since that acts the same as a couple of c oh, yea, BETWEEN should get pushed PS1, Line 724: re-enable when documenting : // Impala 2.8. > Aren't we documenting Impala 2.8 now or is this some intermediate stage? these docs will release with Kudu 1.2, which will release prior to Impala 2.8 being available. We'll update them again for Impala 2.8 in a couple weeks PS1, Line 941: 8 > I thought it was still true. You have to alter the TBLPROPERTIES kudu.table ah, didn't know that. -- To view, visit http://gerrit.cloudera.org:8080/5676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
