Alexey Serbin has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: PS1, Line 80: 2_t len = Is the case of parsed_len == 0 stopped representing a corrupted block? I understand that comparison like 'if (*parsed_len < 0)' does not make sense since parsed_len is uint32_t, but what about the boundary case? PS1, Line 144: AndParseHeader()); nit: consider to be more explicit here: if (PREDICT_FALSE(footer_->incompatible_features() != 0)) { ... } http://gerrit.cloudera.org:8080/#/c/5678/2/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc: PS2, Line 71: const char kMagicStringV1[] = "kuducfil"; : const char kMagicStringV2[] = "kuducfl2"; : const int kMagicLength = 8; What about: const size_t kMagicLength = 8; const char kMagicStringV1[] = "kuducfil"; const char kMagicStringV2[] = "kuducfl2"; static_assert(sizeof(kMagicStringV1) == kMagicLength + 1, "wrong magic length"); static_assert(sizeof(kMagicStringV2) == kMagicLength + 1, "wrong magic length"); -- To view, visit http://gerrit.cloudera.org:8080/5678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13999de3d406fb184cea3e6e8d52ffd80b8d8ee3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
