Adar Dembo has posted comments on this change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5679/3/src/kudu/cfile/block_compression.cc File src/kudu/cfile/block_compression.cc: Line 152: // In CFile v2, we ensure that compressed size <= uncompressed size. I found this statement a little confusing w.r.t. the actual behavior in CompressedBlockBuilder::Compress() (the part that elides compression if compressed_size == uncompressed_size). Perhaps: "// CFile V2 guarantees that compressed size <= uncompressed size (though, as per the file format, if the two are equal the file data was not compressed)" ? -- To view, visit http://gerrit.cloudera.org:8080/5679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8306f1f2139ebf7500a83ee46b4ccd6c7b5e137f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
