Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration ......................................................................
Patch Set 1: (5 comments) Thanks for the patch! BTW, it's helpful to view the generated documentation as well as the markup, to verify that the markup works well. To do that I've got the "Asciidoctor.js Live Preview" Google Chrome extension installed, and then I just navigate to the file on my filesystem (i.e. file:///...) and it renders it as it would render on the website. http://gerrit.cloudera.org:8080/#/c/5728/1/docs/administration.adoc File docs/administration.adoc: PS1, Line 229: * Identify and record the directory where the master's data lives. If using Kudu system packages, : the default value is /var/lib/kudu/master, but it may be customized via the `fs_wal_dir` : configuration parameter. I think the note about fs_data_dirs should be added to this bullet point rather than to a subset of the command examples. Then, also note here that if you've set fs_data_dirs to something other than the value of fs_wal_dir, it should be explicitly included in every command below where fs_wal_dir is also included. Line 292: NOTE:If the existing master's `fs_data_dirs` parameter is configured, you should also add it as a parameter of this format tool. Just so I understand, you've configured your _master_ with multiple data directories? What was the motivation for that? Consistency with the tserver configuration? I'm asking because the master only manages the singleton catalog tablet, and so it's incredibly unlikely to fill up a single disk let alone multiple disks. Line 323: Nit: reformat this new paragraph so that it adheres to the line wrapping guideline (the dashed red vertical line) used by gerrit. PS1, Line 325: list of masters, both new and existing Replace the highlighted section with "list of all of the masters" PS1, Line 418: * Identify and record the directory where the master's data lives. If using Kudu system packages, : the default value is /var/lib/kudu/master, but it may be customized via the `fs_wal_dir` : configuration parameter. The same change should be made for this workflow. -- To view, visit http://gerrit.cloudera.org:8080/5728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e469bc23b650f3b99c785311acc665ac20f33ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: zhen.zhang <zhangz...@xiaomi.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
